magento/magento2#23143: Code optimization for the offline shipping methods

[atwixfirster]

Description (*)

PR keeps solution for #23143: Code optimization for the offline shipping methods.

Fixed Issues (if relevant)

1. Code optimization for the offline shipping methods. #23143: Code optimization for the offline shipping methods.

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[dmytro-ch]

Hi @atwixfirster,
once all the automated tests passed please squash all commits into a single one in order to clean up history. :)
Thank you!

[m2-assistant]

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[atwixfirster]

Hi @atwixfirster,
once all the automated tests passed please squash all commits into a single one in order to clean up history. :)
Thank you!

@dmytro-ch , I think we can skip Static Test result here:

because Magento\OfflineShipping\Model\Carrier\Pickup::collectRates implements function declaration from the parent class.

/**
     * @param RateRequest $request
     * @return \Magento\Shipping\Model\Rate\Result
     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
     */
    public function collectRates(RateRequest $request)
    {
        // Pickup shipping method is not supported in Magento2 yet.
        return false;
    }

Please review.

Thank you!

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-5215 has been created to process this Pull Request

[soleksii]

✔️ QA Passed

[m2-assistant]

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.