-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Backport] Don't load product collection in review observer #23094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
magento-engcom-team
merged 7 commits into
magento:2.2-develop
from
Den4ik:back-port-pull-21200
Jul 12, 2019
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2b11ea6
Refactoring review module (magento/community-features#57)
Den4ik 643ea4f
magento/magento2#21200: Fulltext collection size fix.
p-bystritsky a29bbec
magento/magento2#21200: Static test fix.
p-bystritsky 09f124c
[Review] Remove return type for php 7.0 supporting
Den4ik 49e6843
Merge branch '2.2-develop' into back-port-pull-21200
Den4ik 2e17c71
Merge remote-tracking branch 'mainline/2.2-develop' into back-port-pu…
engcom-Foxtrot 4fdc872
magento/magento2#23094: Static test fixed.
engcom-Foxtrot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 0 additions & 58 deletions
58
app/code/Magento/Review/Block/Product/Compare/ListCompare/Plugin/Review.php
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
<?php | ||
/** | ||
* Copyright © Magento, Inc. All rights reserved. | ||
* See COPYING.txt for license details. | ||
*/ | ||
declare(strict_types=1); | ||
|
||
namespace Magento\Review\Model; | ||
|
||
use Magento\Framework\Model\AbstractModel; | ||
use Magento\Review\Model\ResourceModel\Review\Summary\CollectionFactory as SummaryCollectionFactory; | ||
|
||
/** | ||
* ReviewSummary model. | ||
*/ | ||
class ReviewSummary | ||
{ | ||
/** | ||
* @var SummaryCollectionFactory | ||
*/ | ||
private $summaryCollectionFactory; | ||
|
||
/** | ||
* @param SummaryCollectionFactory $sumColFactory | ||
*/ | ||
public function __construct( | ||
SummaryCollectionFactory $sumColFactory | ||
) { | ||
$this->summaryCollectionFactory = $sumColFactory; | ||
} | ||
|
||
/** | ||
* Append review summary data to product | ||
* | ||
* @param AbstractModel $object | ||
* @param int $storeId | ||
* @param int $entityType | ||
*/ | ||
public function appendSummaryDataToObject(AbstractModel $object, int $storeId, int $entityType = 1): void | ||
{ | ||
$summary = $this->summaryCollectionFactory->create() | ||
->addEntityFilter($object->getId(), $entityType) | ||
->addStoreFilter($storeId) | ||
->getFirstItem(); | ||
$object->addData( | ||
[ | ||
'reviews_count' => $summary->getData('reviews_count'), | ||
'rating_summary' => $summary->getData('rating_summary') | ||
] | ||
); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.