Skip to content

Store view label not in the middle of panel #22926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2019

Conversation

speedy008
Copy link
Contributor

@speedy008 speedy008 commented May 17, 2019

Description (*)

Store view label not in the middle of panel

Fixed Issues (if relevant)

  1. Store view label not in the middle of panel #22924: Store view label not in the middle of panel

Manual testing scenarios (*)

  1. Login to admin panel
  2. Content -> Design -> Configuration -> Edit any theme

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 17, 2019

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @speedy008. Thanks for collaboration. Please fix static tests.

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5124 has been created to process this Pull Request

@speedy008 speedy008 requested a review from VladimirZaets May 20, 2019 05:24
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5124 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request May 24, 2019
@magento-engcom-team magento-engcom-team merged commit 6ade14b into magento:2.3-develop May 24, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 24, 2019

Hi @speedy008, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants