Skip to content

Store view label not in the middle of panel #22926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 24, 2019
Merged

Store view label not in the middle of panel #22926

merged 3 commits into from
May 24, 2019

Conversation

speedy008
Copy link
Contributor

@speedy008 speedy008 commented May 17, 2019 •
edited
Loading

Description (*)

Store view label not in the middle of panel

Fixed Issues (if relevant)

  1. Store view label not in the middle of panel #22924: Store view label not in the middle of panel

Manual testing scenarios (*)

  1. Login to admin panel
  2. Content -> Design -> Configuration -> Edit any theme

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 17, 2019

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned VladimirZaets May 17, 2019
VladimirZaets
VladimirZaets requested changes May 17, 2019
View reviewed changes
Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @speedy008. Thanks for collaboration. Please fix static tests.

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5124 has been created to process this Pull Request

@speedy008 speedy008 requested a review from VladimirZaets May 20, 2019 05:24
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5124 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this May 21, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@Nazar65 Nazar65 self-assigned this May 21, 2019
@VasylShvorak VasylShvorak mentioned this pull request May 22, 2019
Closed
4 tasks
magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request May 24, 2019
@sidolov
ENGCOM-5124: Store view label not in the middle of panel magento#22926
f85071c
@magento-engcom-team magento-engcom-team merged commit 6ade14b into magento:2.3-develop May 24, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 24, 2019

Hi @speedy008, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 24, 2019
@dipti2jcommerce dipti2jcommerce mentioned this pull request May 24, 2019
Open
4 tasks
@krishprakash krishprakash mentioned this pull request Jun 6, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@Nazar65 Nazar65

@VladimirZaets VladimirZaets

@VasylShvorak VasylShvorak

Labels
Area: Design/Frontend Cleanup Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@speedy008 @magento-engcom-team @VasylShvorak @VladimirZaets @Nazar65