Skip to content

only show customer account sections if payment method is active #22850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2019
Merged

only show customer account sections if payment method is active #22850

merged 1 commit into from
May 23, 2019

Conversation

torhoehn
Copy link
Contributor

Description (*)

Stored Payment Methods and Billing Agreements should only be shown if related payment method is active.
900f7cac-7de5-11e6-88b9-31fe6fe65f38

Fixed Issues (if relevant)

  1. Disabled payment methods show in Customer Dashboard #6659: Disabled payment methods show in Customer Dashboard

Manual testing scenarios (*)

  1. Active payment method PayPal => Billing Agreements will be show
  2. Activate payment method Braintree => Stored Payment methods will be shown
  3. Both sections now are hidden by default, because the payment methods are deactivated by default

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 12, 2019

Hi @torhoehn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, thank you for the review.
ENGCOM-5105 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented May 23, 2019

Hi @torhoehn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 23, 2019
@torhoehn torhoehn deleted the feature/payment-customer-account-sections branch May 23, 2019 13:00
@YevSent
Copy link
Contributor

YevSent commented Jul 31, 2019

This fix is incorrect, Vault should not have a dependency on Braintree, these changes added circular dependencies between Braintree and Vault modules.

The possibility to show payment tokens should be provided by each payment integration, as only the payment integration knows about its payment tokens. The block in Vault module should have a composite which will be extended by payment integrations and the block should check from the composite is there are any available payment tokens to render.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants