-
Notifications
You must be signed in to change notification settings - Fork 9.4k
only show customer account sections if payment method is active #22850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only show customer account sections if payment method is active #22850
Conversation
Hi @torhoehn. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @Karlasa, thank you for the review. |
✔️ QA passed |
Hi @torhoehn, thank you for your contribution! |
This fix is incorrect, Vault should not have a dependency on Braintree, these changes added circular dependencies between Braintree and Vault modules. The possibility to show payment tokens should be provided by each payment integration, as only the payment integration knows about its payment tokens. The block in Vault module should have a composite which will be extended by payment integrations and the block should check from the composite is there are any available payment tokens to render. |
Description (*)
Stored Payment Methods and Billing Agreements should only be shown if related payment method is active.

Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)