Skip to content

issue #22676 fixed - Compare Products counter, and My Wish List count… #22742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 6, 2019

Description (*)

I have added vertical-align:middle; to align the Compare Products counter, and My Wish List counter in the sidebar.

Fixed Issues (if relevant)

  1. Compare Products counter, and My Wish List counter vertical not aligned #22676: Compare Products counter, and My Wish List counter vertical not aligned

Manual testing scenarios (*)

  1. Added Products to Wishlist and Compare
  2. Opened Customer Account section to check the alignment in the sidebar

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented May 6, 2019

Hi @sanjaychouhan-webkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, thank you for the review.
ENGCOM-5068 has been created to process this Pull Request

@soleksii soleksii self-assigned this May 7, 2019
@Nazar65 Nazar65 self-assigned this May 8, 2019
@soleksii
Copy link

soleksii commented May 8, 2019

✔️ QA Passed

Before:

before

After:

after

magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request May 23, 2019
@magento-engcom-team magento-engcom-team merged commit 6c69943 into magento:2.3-develop May 23, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 23, 2019

Hi @sanjaychouhan-webkul, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants