Skip to content

Fixed Issue #20234 #22694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from May 23, 2019
Merged

Fixed Issue #20234 #22694

merged 3 commits into from May 23, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 4, 2019 •
edited by ghost
Loading

Description (*)

Review text Should be capitalized

Fixed Issues (if relevant)

  1. magento/magento2#<20234>: Review text Should be capitalized

Manual testing scenarios (*)

  1. Navigate to product listing page.
  2. Change the mode from grid to list.
  3. Now you can see "add your review" and "review" text in this format
    Add Your Review
    Review

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @surbhi-ranosys. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 4, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Karlasa
Copy link
Contributor

Karlasa commented May 4, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@Karlasa Karlasa self-requested a review May 4, 2019 19:20
@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your Magento instance.
Admin access: https://i-22694-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@Karlasa
Copy link
Contributor

Karlasa commented May 4, 2019

Hi!
@surbhi-ranosys could you please sign CLA, so wo could continue processing this pull request :)

Cheers,
Karla

@ghost
Copy link
Author

ghost commented May 7, 2019 •
edited by ghost
Loading

Hello @Karlasa

I have signed CLA, Can you please check now?

@Karlasa
Copy link
Contributor

Karlasa commented May 7, 2019

@surbhi-ranosys, Thank You CLA is signed, could you now look the comment I left in code review :)

@ghost ghost assigned Karlasa May 16, 2019
@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, thank you for the review.
ENGCOM-5120 has been created to process this Pull Request

@soleksii soleksii self-assigned this May 16, 2019
@IvanPletnyov IvanPletnyov self-assigned this May 16, 2019
@soleksii
Copy link

Hi @surbhi-ranosys !
Could you please correct text transform and on Blank theme too!?
blank

Thanks!

@ghost
Copy link
Author

ghost commented May 16, 2019

Hi @stoleksiy

I have corrected the text transform for blank them too. Can you please verify it now?

@soleksii
Copy link

Hi @stoleksiy

I have corrected the text transform for blank them too. Can you please verify it now?

Ok. Thanks!

@soleksii
Copy link

✔️ QA Passed

magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request May 23, 2019
@sivaschenko
ENGCOM-5120: Fixed Issue magento#20234 magento#22694
dc583c9
@magento-engcom-team magento-engcom-team merged commit 66b78dd into magento:2.3-develop May 23, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 23, 2019

Hi @surbhi-ranosys, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 23, 2019
@dipti2jcommerce dipti2jcommerce mentioned this pull request May 24, 2019
Open
4 tasks
@ghost ghost added Partner: Ranosys Pull Request is created by Ranosys Technologies partners-contribution Pull Request is created by Magento Partner labels May 28, 2019
@krishprakash krishprakash mentioned this pull request Jul 3, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Karlasa Karlasa

@IvanPletnyov IvanPletnyov

@soleksii soleksii

Labels
Area: Design/Frontend Award: bug fix Partner: Ranosys Pull Request is created by Ranosys Technologies partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@magento-cicd2 @Karlasa @magento-engcom-team @soleksii @IvanPletnyov