Skip to content

[Frontend] Fixing the accessibility standards violation #21851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Mar 20, 2019

Description (*)

This PR reverts the changes made in #20861, because those changes violate the accessibility standards when navigating with keyboard.

2.1 Keyboard Accessible: Make all functionality available from a keyboard.
Source: https://www.w3.org/TR/WCAG20/#keyboard-operation

Also the confirmed issue #20859 isn't actual.

So we should keep the shadow on focus for radio and checkboxes to make the keyboard navigation smoother.

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios (*)

  1. Open any page with the form containing checkboxes or radio buttons.
  2. You should be able to navigate through the form using keyboard (tab key).
  3. The checkboxes and radio buttons should be highlighted on focus while navigating through the form.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@eduard13 eduard13 requested a review from dmytro-ch March 20, 2019 09:03
@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Area: Lib/Frontend Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 20, 2019
@eduard13 eduard13 changed the title Reverting the PR#20861 changes because of violating accessibility standards [Frontend] Reverting the PR#20861 changes because of violating accessibility standards Mar 20, 2019
@eduard13 eduard13 changed the title [Frontend] Reverting the PR#20861 changes because of violating accessibility standards [Frontend] Fixing the accessibility standards violation Mar 20, 2019
@dmytro-ch dmytro-ch self-assigned this Mar 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4541 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@ghost
Copy link

ghost commented Mar 25, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Lib/Frontend Cleanup Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants