-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix issue with di.xml config merging for classes array argument in case of different sources and the class name difference in leading slash. #20891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…array argument in case of different sources and the class name difference in leading slash.
Hi @swnsma. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
Hi @sivaschenko, thank you for the review. |
@dominicfernando |
Hi @Nazar65, |
Hi @swnsma, thank you for your contribution! |
PR break Backward Compatibility due to merging of configs between general and concrete application level (e.g. adminhtml/frontend) leads to merging of configs (after changes in this PR) but not replacing of configs (before changes in this PR). |
Description
PR to fix the reasons of #20410 (issue #20409).
During research I have discovered bug in config merging from di.xml.
Merging of nested arguments (array) in case of difference in class name (leading slash) in different files can leads to config lost.
Fixed Issues (if relevant)
Manual testing scenarios
Pre-Conditions
Steps to reproduce
php bin/magento setup:upgrade
.php bin/magento cache:flush
Expected results
Actual results
Contribution checklist