Skip to content

[Backport] Empty block rendering in My Account page sidebar fixed using designing changes. #20835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#20630

Description (*)

Empty block rendering in My Account page sidebar fixed using designing changes.

Fixed Issues (if relevant)

  1. Empty block rendering in My Account page sidebar #19139: Empty block rendering in My Account page sidebar

Manual testing scenarios (*)

  1. Create an Account or Sign In
  2. Review left sidebar in My Account section

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost
Copy link

ghost commented Jan 31, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@amol2jcommerce
Copy link
Contributor Author

@mage2pratik Why you close PR?

@mage2pratik
Copy link
Contributor

mage2pratik commented Jan 31, 2019

Hi @amol2jcommerce, I'm closing this PR as a duplicate #20845. Because I'm author of the original PR #20630.
Please refer Magento Code Contributions Guide for more detail. Thanks :)

@ghost
Copy link

ghost commented Jan 31, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@torhoehn torhoehn removed their request for review February 2, 2019 16:26
@mage2pratik mage2pratik closed this Feb 4, 2019
@ghost
Copy link

ghost commented Feb 4, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants