Skip to content

Fixed#20352: displaying html content for file type option on order view admin area #20353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mahesh-rajawat
Copy link
Member

In this PR i have fixed #20352 issue.

File type option value shows html content in admin order view.

Description (*)

Fixed Issues (if relevant)

  1. File type option value shows html content in order, invoice and credit memo emails #20352
  2. ...

Manual testing scenarios (*)

  1. Create a product with file type option.
  2. Place an order with this product by uploading file.
  3. Go to Sales->Order view.
  4. Option value is displaying as link now.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko
Copy link
Member

Hi @maheshWebkul721 , we'd like to merge fixes to 2.3-develop first. If this problem exists on 2.3, could you please port this pull request to 2.3-develop.

@mahesh-rajawat
Copy link
Member Author

Hi @sivaschenko, this problem already fixed in 2.3.

@okorshenko
Copy link
Contributor

Thank you @maheshWebkul721 for a quick response. I can confirm this as well.

@ghost
Copy link

ghost commented Jan 18, 2019

Hi @maheshWebkul721, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@nmalevanec
Copy link
Contributor

Fix already exists in 2.3-develop. No need to port
7699538

@WilliejanB
Copy link

Hi, I use Magento ver. 2.3.5-p1 and this issue still exists in M2 back end and on all transactional emails and PDF's as well. Please let me know how I can solve this?
Aantekening 2020-07-23 013636
order.pdf

@sivaschenko
Copy link
Member

@WilliejanB if this issue can be reproduced on 2.4-develop it would be good to open an issue for it

@WilliejanB
Copy link

Dear Sivaschenko,

Last Friday we updated to M2.4 and the issue is still there! How do I reopen it or do I need to create a new post?

Best regards,
Williejan

@WilliejanB if this issue can be reproduced on 2.4-develop it would be good to open an issue for it

@sivaschenko
Copy link
Member

@WilliejanB I've reopened the issue #20352, thanks for the notification!

@WilliejanB
Copy link

This issue still occurs in Magento ver 2.4.3
In Magento backend admin, in order confirmation emails and PDF documents. So please re-open.

Sales _ Magento Admin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants