Skip to content

[Backport]changes-add-your-review-text-is-not-show-uniformly-in-Mobile-view #20257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

amol2jcommerce
Copy link
Contributor

@amol2jcommerce amol2jcommerce commented Jan 14, 2019

Description (*)

Fixed Issues (if relevant)

  1. add your review text is not show uniformly in Mobile view #20221: add your review text is not show uniformly in Mobile view
  2. Magento 2.2.x

Manual testing scenarios (*)

  1. In mobile view: product listing on home page and on listing page

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Backport for: #20224

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@nuzil
Copy link
Contributor

nuzil commented Jan 14, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @nuzil. Thank you for your request. I'm working on Magento instance for you

@nuzil nuzil self-requested a review January 14, 2019 09:04
@nuzil nuzil self-assigned this Jan 14, 2019
@amol2jcommerce amol2jcommerce changed the title changes-add-your-review-text-is-not-show-uniformly-in-Mobile-view [Backport]changes-add-your-review-text-is-not-show-uniformly-in-Mobile-view Jan 26, 2019
@nuzil nuzil removed their request for review January 28, 2019 15:10
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4006 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 9, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 9, 2019
@sidolov sidolov added this to the Release: 2.2.9 milestone Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants