Skip to content

Conversation

amol2jcommerce
Copy link
Contributor

@amol2jcommerce amol2jcommerce commented Jan 11, 2019

Pull request to 2.2-develop

#20214

Description (*)

Fixed Issues (if relevant)

  1. Hamburger Icon was available on a page where menu was not present. Issue in responsive view #20210: Hamburger Icon was available on a page where menu was not present. Issue in responsive view
  2. Magento version 2.2

Manual testing scenarios (*)

  1. Login to Customer Panel
  2. Place Order for any product
  3. Create invoice and shipment for this order from the backend
  4. Repeat step 1
  5. Open the browser in mobile responsive
  6. Go to my account->my order->view the same order or any other order with the status "complete"
  7. Click on Order Shipment subtab
  8. Click on Print All Shipments
  9. Cancel the option to print the Shipment form
  10. Check the page

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Jan 14, 2019
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-3853 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 16, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@amol2jcommerce amol2jcommerce deleted the Changes-Hamburger-Icon-was-available-on-a-page branch January 22, 2019 08:39
@amol2jcommerce
Copy link
Contributor Author

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@amol2jcommerce
Copy link
Contributor Author

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your request. I'm working on Magento 2.2-develop instance for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants