Skip to content

Conversation

SyntaxKay
Copy link
Contributor

@SyntaxKay SyntaxKay commented Dec 15, 2018

Original Pull Request

#19799

Description (*)

Magento 2.2-develop
Sales Order invoice Update Qty's Button is misaligned

Fixed Issues (if relevant)

1.#19796: Sales Order invoice Update Qty's Button is misaligned

Manual testing scenarios (*)

1.Login to backend-> Order -> View order
2.Generate Invoice -> Items to Invoice -> Check Update Qty's Button

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@aleron75 aleron75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the proposed change, the total column count b/w header (8) and footer(9) differs.
Is it intentional?

@SyntaxKay
Copy link
Contributor Author

@aleron75
I was mistaken with column (9) in footer. I just resolved it

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3734 has been created to process this Pull Request

@sdzhepa
Copy link
Contributor

sdzhepa commented Dec 24, 2018

Hello @speedy008

I have put label On Hold
According to our rules, this PR will be processed after original #19799 will be merged.

Thank you for feedback and collaboration

@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants