Attribute set delete was throwing the 404

[jignesh26]

Description (*)

When admin try to delete the attribute set it throwing the error 404 cause HttpGetActionInterface was missing.

Manual testing scenarios (*)

1. Add new attribute set.
2. try to delete that attribute set.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @jignesh26. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[larsroettig]

@magento-engcom-team give me 2.3-develop instance

[magento-engcom-team]

Hi @larsroettig. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @larsroettig, here is your Magento instance.
Admin access: https://i-19682-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[larsroettig]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @larsroettig. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @larsroettig, here is your new Magento instance.
Admin access: https://pr-19682.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[larsroettig]

✔️ Issues Verified
✔️ Review
✔️ Manual Testing

[sreichel]

FYI: there is another PR that adresses that issue .... #19633

[sivaschenko]

Hi @jignesh26 thanks for your contribution! However, the fix for this issue is already provided earlier. Please see #19633

Closing as a duplicate.

[jignesh26]

@sivaschenko , i think i have provided better solution rather then passing just empty data set to ajax request. i have changed the attribute set action interface and it also changing the Application state.

Please feedback on this.
Thank you.

[sivaschenko]

Hi @jignesh26 the delete operation should be done using POST method (as it does change the application state). The fix in #19633 is ensuring the POST request.

Considering the above, the controller should not be marked by HttpGetActionInterface

[sivaschenko]

Closing this pull request as not actual: the issue #19607 is already fixed

[ghost]

Hi @jignesh26, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.