Removed logic related to columnCountLayoutDepend

[sreichel]

Description (*)

See comment at #19309

@sreichel please consider removal of logic related to columnCountLayoutDepend also. Was never used in M2 but never removed as well.

Fixed Issues (if relevant)

1. n/a

Manual testing scenarios (*)

1. n/a

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @sreichel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[sivaschenko]

Hi @sreichel , thanks for your contribution. Unfortunately removing public/protected functions and properties are backward incompatible changes and cannot be accepted. For now it would be good to mark the functions you think should be removed as deprecated.

I would also get an architecural approval for such changes by creating a pull request with proposition here: https://github.com/magento/architecture

[orlangur]

@sreichel nice!

Please remove testLayoutDependColumnCount completely as it does not make a lot of sense now and we are good to go.

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-3551 has been created to process this Pull Request

[sivaschenko]

Hi @sreichel the changes introduced in this pull request are backward incompatible, if you'd like to remove _columnCountLayoutDepend - please mark it deprecated but do not eliminate any usages/functionality yet.

[orlangur]

@sivaschenko your statement is incorrect. This is Magento 1 reminant and never did anything useful in Magento 2.0 GA or later.

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-3551 has been created to process this Pull Request

[orlangur]

@sivaschenko @sidolov please clarify if anything left to be done here taking into consideration #19349 (comment).

[sidolov]

Please, mark property as deprecated due to backward compatibility instead of remove.

[orlangur]

Thanks Stas, somehow I overlooked it, while "do not eliminate any usages/functionality yet" looks completely not correct to me.

[sreichel]

@sidolov @slitvyachenko @orlangur Please close. Not wasting my time here anymore .... "please consider removal of logic related to columnCountLayoutDepend also. Was never used in M2 but never removed as well."

[ghost]

Hi @sreichel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.