Skip to content

Conversation

@torhoehn
Copy link
Contributor

Original Pull Request

#18808

Description (*)

before these two observers checkout_cart_product_add_after, checkout_cart_product_update_after cart item is not saved into the database the object is only created and in the object price was not set but custom price was set so there was no issue of custom price, we could have added the price in the item from two files:
app/code/Magento/Quote/Model/Quote/Item/Processor.php and
app/code/Magento/Quote/Model/Quote.php
I have added the price in this file app/code/Magento/Quote/Model/Quote/Item/Processor.php

Fixed Issues (if relevant)

  1. Quote Item Prices are NULL in cart related events. #18685: Quote Item Prices are NULL in cart related events

Manual testing scenarios (*)

  1. create a module which has observers for these two events checkout_cart_product_add_after, checkout_cart_product_update_after cart
  2. now in the observer try to get the added item price by calling $observer->getEvent()->getQuoteItem()->getPrice()

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko sivaschenko self-assigned this Nov 22, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3513 has been created to process this Pull Request

@sidolov
Copy link
Contributor

sidolov commented Dec 22, 2018

Hi @torhoehn , looks like port for described PR already created by author of the original PR: #18806
I'm closing this PR as duplicate.
Thank you for collaboration!

@sidolov sidolov closed this Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants