Skip to content

Conversation

@p-bystritsky
Copy link
Contributor

@p-bystritsky p-bystritsky commented Nov 12, 2018

Forwardport for #18959 and #7849

"Not yet calculated" for the tax in the summary section in the checkout was not being translated.

Description (*)

Now the correct function call for js translations is made.

Fixed Issues (if relevant)

  1. "Not yet calculated" for the tax in the summary section in the checkout is not translatable #18939: "Not yet calculated" for the tax in the summary section in the checkout is not translatable
  2. M2.x.x Translation Missing in Checkout for Tax #7849: M2.x.x Translation Missing in Checkout for Tax

Manual testing scenarios (*)

  1. Setup a two-store site where the default store uses "en_Us" as the language and the second store uses "es_ES" (Spanish ).

  2. Add Spanish translation for the text: "Not yet calculated" through the design section. i.e, in the file: app/design/frontend/<Package>/<theme>/i18n/es_ES.csv.

     "Not yet calculated","Aún no calculado"
    
  3. Now on the frontend, switch to Spanish store. Then add a product to the cart and go for checkout.

  4. In the payment step, under the summary section, you will see "Not yet calculated" is not translated for the Tax eventhough the same text corresponding to Shipping is translated.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @p-bystritsky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Nov 12, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 12, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3443 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @p-bystritsky. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants