Skip to content

Conversation

@p-bystritsky
Copy link
Contributor

Forwardport for #16887

Preconditions

  1. Magento 2.2.3 or 2.2.4 or 2.2.5
  2. Add the following script to the product page:
    <script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script>

Steps to reproduce

  1. Flush cache
  2. Open dev-console in your browser
  3. Reload page many times

Expected result

Console without errors

Actual result

  1. Sometime we'll have this error:
    console

Tech notes

Time to time created iframe on following line: https://github.com/magento/magento2/blob/2.2-develop/lib/web/jquery.js#L3123

Our change add try-catch to this method, and when error appears - we just returning an empty array.

@magento-engcom-team
Copy link
Contributor

Hi @p-bystritsky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3440 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @p-bystritsky. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@fbkaasa
Copy link

fbkaasa commented Jan 11, 2019

What about clients on 2.2.* ? Will there be provided a patch to fix this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants