Skip to content

Conversation

@vpodorozh
Copy link
Contributor

…om parent theme

  • forward port unit tests from 2.2-develop branch

Description ( #17833 )

Forward port unit test for \Magento\Framework\Translate from 2.2-develop branch.
Note: current PR was created from this PR #19018 , changes were not submitted into #19018 because it was already accepted and merged.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

… theme

- forward port unit tests from 2.2-develop branch
@magento-engcom-team magento-engcom-team added Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Component: Framework/Translate USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to translation in Catalog use just Catalog labels Nov 10, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vpodorozh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

… theme

- forward port unit tests from 2.2-develop branch - declare strict types
@vpodorozh
Copy link
Contributor Author

Hey guys - what should I do in case Travis-ci has failed on Integration test due to: The job exceeded the maximum time limit for jobs, and has been terminated. ?
Just skip it?

@rogyar
Copy link
Contributor

rogyar commented Nov 13, 2018

Yes, just skip it :)

@magento-engcom-team magento-engcom-team merged commit fe73cf0 into magento:2.3-develop Nov 14, 2018
magento-engcom-team pushed a commit that referenced this pull request Nov 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vpodorozh. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Framework/Translate USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to translation in Catalog use just Catalog Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants