Added option to exclude discount for minimum order amount calculation #19136
Conversation
There was a problem hiding this comment.
Hi @ccasciotti thanks for the contribution, please see my code review notes
| @@ -2289,7 +2298,11 @@ public function validateMinimumAmount($multishipping = false) | |||
| $baseTotal = 0; | |||
| foreach ($addresses as $address) { | |||
| $taxes = ($taxInclude) ? $address->getBaseTaxAmount() : 0; | |||
| $baseTotal += $address->getBaseSubtotalWithDiscount() + $taxes; | |||
| if ($includeDiscount) { | |||
There was a problem hiding this comment.
The current implementation of getBaseSubtotalWithDiscount method is as simple as $this->getBaseSubtotal() + $this->getBaseDiscountAmount(). If there is no bugs related to tax in current implementation I would suggest simply returning $this->getBaseSubtotal() + $taxes or $address->getBaseSubtotalWithDiscount() + $taxes depending on includeDiscount configuration value.
Please consider the same for other instances.
There was a problem hiding this comment.
Hi @sivaschenko,
changes implemented
|
Hi @sivaschenko, thank you for the review. |
sivaschenko
changed the title
|
Hi @ccasciotti, thank you for your contribution! |
…um order amount calculation #19136
|
Hi @ccasciotti. Thank you for your contribution. |
Description
This PR adds option for store manager to include or exclude discount amount from minimum order amount calculation. Sometimes client wants to exclude discount amount from minimum order and want that only subtotal is used. The default option is set to "Yes" so Magento will use the current behavior.
Fixed Issues (if relevant)
none
Manual testing scenarios
Contribution checklist