Skip to content

Add additional check if password hash is empty in auth process #19066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Add additional check if password hash is empty in auth process #19066

merged 1 commit into from
Nov 6, 2018

Conversation

progreg
Copy link
Contributor

@progreg progreg commented Nov 5, 2018

Description

Added additional check for password hash if the customer was created without a password from admin area.

Fixed Issues

  1. User created by admin cannot login #19060: User created by admin cannot login

Manual testing scenarios

  1. Create customer at admin area (without password)
  2. Try to login at frontend as a customer

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @progreg. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Nov 5, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3390 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @progreg. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Copy link

@salehawal salehawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i also found a isue in this methud, after changing the return value format it did work fine

public function isValidHash($password, $hash)
{
    $this->explodePasswordHash($hash);

    foreach ($this->getPasswordVersion() as $hashVersion) {
        $password = $this->hash($this->getPasswordSalt() . $password, $hashVersion);
    }

    $hash = $this->getPasswordHash();
    return Security::compareStrings(
        $password,
        $hash
    );
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants