Skip to content

magento/magento2#18990: Shipping address is not validated in checkout… #19038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 12, 2018
Merged

magento/magento2#18990: Shipping address is not validated in checkout… #19038

merged 3 commits into from
Dec 12, 2018

Conversation

StasKozar
Copy link
Contributor

@StasKozar
magento#18990: Shipping address is not validated in checkout when pro…
43e2c4d 
…ceeding step as logged in user with default shipping address
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Nov 2, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @StasKozar. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Nov 5, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3386 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request Dec 12, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 66c1155 into magento:2.3-develop Dec 12, 2018
@magento-engcom-team
Copy link
Contributor

Hi @StasKozar. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

magento-engcom-team pushed a commit that referenced this pull request Dec 12, 2018
@nmalevanec
ENGCOM-3386: #18990: Shipping address is not validated in checkout… #…
74e4bec 
…19038. Fix unit test.
magento-engcom-team pushed a commit that referenced this pull request Dec 12, 2018
@sivaschenko
ENGCOM-3386: #18990: Shipping address is not validated in checkout… #…
8831abe 
…19038
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

Labels
Area: Frontend Award: bug fix Award: MFTF test coverage Component: Checkout Component: Config Component: Customer Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@StasKozar @magento-cicd2 @magento-engcom-team @VladimirZaets