Skip to content

Conversation

@cezary-zeglen
Copy link
Contributor

Up-port of #17854

Description

Currently if you enable custom design theme for category the translations of selected theme are not used. This commit fixes the problem.

Fixed Issues (if relevant)

#17625

Manual testing scenarios

(Copied from #17625 )

  1. Enable Magento_Blank for the website
  2. Create a category and set Magento_Luma as it's theme
  3. Add a translation to the /i18n/ directory of Magento_Luma
  4. Flush caches
  5. The translation is now not applied.
    Commit changes point 5. so the translation is being applied

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @cezary-zeglen. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Nov 1, 2018
@orlangur
Copy link
Contributor

orlangur commented Nov 1, 2018

Cc: @slavvka

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 1, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3365 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@cezary-zeglen thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @cezary-zeglen. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants