Skip to content

Conversation

tdgroot
Copy link
Member

@tdgroot tdgroot commented Nov 1, 2018

Original Pull Request

#18700

Reload cart totals when cart data changes

Description (*)

When cart data changes on cart view, the totals need to be reloaded. For example, when the qty changes, the totals of the cart data change as well.

This normally doesn't happen in default Magento, because cart mutations reload the entire page. I stumbled upon this problem when creating an extension that allows the customer to change qty without reloading the page.

Manual testing scenarios (*)

I can't really provide steps to reproduce my situation, because core Magento doesn't do javascript cart mutations on the cart view. But, when adding items to cart, the totals should be rendered properly. This change shouldn't affect the usual totals estimation. So here you go:

  • Add an item to the cart.
  • The totals should be initialized.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @tdgroot. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Nov 1, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 1, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3356 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @tdgroot. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@tdgroot tdgroot deleted the 2.2-develop-PR-port-18700 branch November 9, 2018 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants