Skip to content

Conversation

@Shubham0492
Copy link

Description
I have checked that if there is any validation error exist then after click save button configurable-matrix data remove.You can check the file app/code/Magento/ConfigurableProduct/view/adminhtml/web/js/variations/variations.js in function serializeData due to fatal error comes.Now I have added condition that if there is any validation error exist then configurable-matrix data will not remove and after submit form all value will exist and product will successfully save.

Fixed Issues (if relevant)
1 - #18082: Fatal Error when save configurable product in Magento 2.2.5

Manual testing scenarios
Add new configurable product with name and sku of 63 characters length For Example: "Amzer 203877 Kristal FULL HD Tempered Glass for OnePlus 6 Clear".
Now click on "Create Configuration" button.
Now, When you try to save it's configuration, It shows client side validation error for child products SKUs. Decrease length of child product's SKUs and then save the product. It generates a error report as attached.But after apply changes product successfully saved.

Contribution checklist
Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 22, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @Shubham-Webkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@mahesh-rajawat mahesh-rajawat changed the base branch from 2.3-develop to 2.2-develop October 23, 2018 04:23
@sidolov
Copy link
Contributor

sidolov commented Oct 23, 2018

Hi @Shubham-Webkul , looks like you made some commits with email different than in your GitHub profile, please, add email from commits to your profile!
Thank you!

@Shubham0492
Copy link
Author

@sidolov as i have checked that i done all commits using [email protected] email.Please let me know clearly what mistake i am doing.So that i can fix it.
Thank You!

@Shubham0492
Copy link
Author

@sidolov I have added all emails which used to make commit.
Thank You!

@Shubham0492
Copy link
Author

#SQUASHTOBERFEST

@orlangur
Copy link
Contributor

orlangur commented Nov 7, 2018

#18461 seems to be an exact backport of 2.3.x fix.

@Shubham-Webkul thanks for your endeavours!

@orlangur orlangur closed this Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants