Skip to content

Conversation

@mage2pratik
Copy link
Contributor

Original Pull Request

#18670

Description (*)

In magento2/#18280 this was added to sort the collection ...

use Magento\Framework\Data\Collection;`
...
->setDirection(Collection::SORT_ORDER_ASC)

Instead we can use setAscendingDirection(). If not Magento\Framework\Api\SortOrder::SORT_ASC would be more correct. (?)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sreichel
Copy link
Contributor

@mage2pratik there is already a PR for 2.3 ;)

See #18671

@okorshenko
Copy link
Contributor

Duplicate of #18671

@okorshenko okorshenko marked this as a duplicate of #18671 Oct 19, 2018
@okorshenko okorshenko closed this Oct 19, 2018
@okorshenko okorshenko self-assigned this Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants