Skip to content

Conversation

@gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Oct 17, 2018

Original Pull Request

#18365

Description

With this fix, developers can add custom catalog image types like SVG from di.xml configuration.
In Catalog ImageUploader allowed extensions can be customized, but allowed mime types are hardcoded in the class into a private property. (with no getter method). This PR solves this limitation.

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@larsroettig
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @larsroettig. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @larsroettig, here is your new Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/pr-18662//admin
Login: admin Password: 123123q

@larsroettig larsroettig self-requested a review October 17, 2018 10:12
@larsroettig
Copy link
Member

  • CodeReview
  • Maunal Testing Backend

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 17, 2018
@magento-engcom-team
Copy link
Contributor

Hi @larsroettig, thank you for the review.
ENGCOM-3208 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3208 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit d653d75 into magento:2.2-develop Oct 17, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 17, 2018
@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants