-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Backport] move hardcoded MIME types from class private to DI configuration #18662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] move hardcoded MIME types from class private to DI configuration #18662
Conversation
|
Hi @gelanivishal. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
@magento-engcom-team give me test instance |
|
Hi @larsroettig. Thank you for your request. I'm working on Magento instance for you |
|
Hi @larsroettig, here is your new Magento instance. |
|
|
Hi @larsroettig, thank you for the review. |
|
Hi @orlangur, thank you for the review. |
…to DI configuration #18662
|
Hi @gelanivishal. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Original Pull Request
#18365
Description
With this fix, developers can add custom catalog image types like SVG from di.xml configuration.
In Catalog ImageUploader allowed extensions can be customized, but allowed mime types are hardcoded in the class into a private property. (with no getter method). This PR solves this limitation.