Skip to content

[BACKPORT] Use version_compare to compare version strings correctly #18423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[BACKPORT] Use version_compare to compare version strings correctly #18423

wants to merge 1 commit into from

Conversation

@lewisvoncken
Copy link
Contributor

@lewisvoncken lewisvoncken commented Oct 6, 2018

Description

Backport of PR #18173

Version numbers were compared with regular alphanumeric string comparison <, which results in 1.10 < 1.9. Instead, version_compare should be used

Manual testing scenarios

  1. Update a module from version 1.9.0 to 1.10.0 and open the shop in the browser
  2. Expected message: "run setup:upgrade", not "run composer install"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko
Copy link
Contributor

okorshenko commented Oct 7, 2018

Hi @lewisvoncken
Please look at the broken tests. Thank you

@okorshenko okorshenko self-assigned this Oct 7, 2018
@okorshenko
Copy link
Contributor

okorshenko commented Oct 19, 2018

Hi @lewisvoncken Could you please let us know if you are going to proceed with this PR. Thank you

@okorshenko
Copy link
Contributor

okorshenko commented Oct 22, 2018

Hi @lewisvoncken
we are closing this PR due to inactivity
Feel free to reopen it once ready
Thank you

@okorshenko okorshenko closed this Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schmengler schmengler Awaiting requested review from schmengler

@slavvka slavvka Awaiting requested review from slavvka

Assignees

@okorshenko okorshenko

Labels

Component: Framework/Module Event: squashtoberfest Partner: Experius partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lewisvoncken @okorshenko @magento-engcom-team