Skip to content

Conversation

@dmytro-ch
Copy link
Contributor

@dmytro-ch dmytro-ch commented Oct 6, 2018

Original PR: #18308

Description

The issue appeared because of the success, notice and warning messages considered as error ones.

Fixed Issues (if relevant)

  1. Cannot edit customer using inline edit if password is expired #18162: Cannot edit customer using inline edit if password is expired

Manual testing scenarios

  1. Set admin/security/password_is_forced to 0 (Recommended).
  2. Make sure Password Lifetime is past so the message It's time to change your password. is shown.
  3. Open customer grid and try to edit and save using inline editor.

Expected result

  1. Customer is saved.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Customer Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants