Fixes #18357 - SQL error when table prefix used.

[pocallaghan]

Description

Hard-coded table names cause errors if a table prefix, passing the table name to getTable resolves this.

Fixed Issues (if relevant)

1. checkout_agreement_store doesn't exist #18357

Manual testing scenarios

1. Create a store using table prefixes
2. Navigate to Store > Terms and Conditions in the admin backend
3. Without the patch, errors are generated

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[okorshenko]

Hi @pocallaghan
Thank you for your contribution. Could you please sign Contributor License Agreement so that we can proceed with pull request processing. Just follow the URL: https://cla.dev.magento.com/magento/magento2?pullRequest=18412 to sign the CLA

Thank you

[okorshenko]

thank you for your fix. The solution looks reasonable. The reason why this issue appeared is that there is not an integration test for this case. We are running integration tests with and w/o table prefixes to make sure that such issues won't appear.

Please cover this case with the integration test (and earn additional contribution points :) ) to avoid a regression issue for your solution.

Also, could you please fix broken static tests.
Thank you

[sreichel]

@okobchenko is getResource() really neccessary?

[magento-engcom-team]

Hi @pocallaghan. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.