Skip to content

Cleaner documentation for Travis CI static tests #18386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 5, 2019
Merged

Cleaner documentation for Travis CI static tests #18386

merged 5 commits into from
Apr 5, 2019

Conversation

Thundar
Copy link
Contributor

@Thundar Thundar commented Oct 4, 2018

Description

This fix applies only to version 2.3.
Travis CI is failing static test for the commited files. The reason is that the comments does not adhere perfectly to the standard, especially on {@inheritdoc} usage.
Reference: inheritdoc documentation

Manual testing scenarios

  1. Run static tests on Travis without this commit to see the previous errors. Example: Pull request [Forwardport] 17968 Fix Customer custom attributes lost after save #18373 Travis CI Build Exception on customer edit under restricted admin access #13951 Job Exception on customer edit under restricted admin access #13951.3
  2. See Travis CI results on this pull request

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@Thundar Thundar changed the title Cleaner Travis CI results on static tests Cleaner documentation for Travis CI static tests Oct 4, 2018
@josefbehr josefbehr self-assigned this Oct 7, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 7, 2018
@magento-engcom-team
Copy link
Contributor

Hi @josefbehr, thank you for the review.
ENGCOM-3118 has been created to process this Pull Request

@josefbehr josefbehr closed this Oct 7, 2018
@okorshenko okorshenko reopened this Oct 7, 2018
@Thundar Thundar added Partner: The Site Up partners-contribution Pull Request is created by Magento Partner labels Oct 11, 2018
@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Thundar
❌ josefbehr

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4629 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2019

Hi @Thundar, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants