[Backport 2.2-develop] Refactor Mass Order Cancel code to use Interface #18377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have observed that MassAction Cancel is using the collection for orders cancel, whereas Order Cancel (order cancel from order edit section) is using Interface to put the order on hold. So, I have refactor the Mass Order Cancel code to use Sales Order Interface. # Conflicts: # app/code/Magento/Sales/Controller/Adminhtml/Order/MassCancel.php
…#14630 - Merge Pull Request magento#14630 from AnshuMishra17/magento2:patch-2 - Merged commits: 1. dab8c38 2. 97f5978 3. 2b4ca2e # Conflicts: # app/code/Magento/Sales/Controller/Adminhtml/Order/MassCancel.php # app/code/Magento/Sales/Test/Unit/Controller/Adminhtml/Order/MassCancelTest.php
Jeroenll
added
Release Line: 2.2
partners-contribution
Member
Author
|
@sidolov Can you also process this PR since you also did the original one in 2.3 branch? |
sidolov
approved these changes
Oct 4, 2018
Contributor
|
Hi @sidolov, thank you for the review. |
Contributor
|
Hi @JeroenVanLeusden. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #14630
Description
I have observed that MassAction Cancel is using the collection for orders cancel, whereas Order Cancel (order cancel from order edit section) is using Interface to put the order on hold.
So, I have refactor the Mass Order Cancel code to use Sales Order Interface.
Manual testing scenarios
Contribution checklist