Skip to content

Conversation

@sambolek
Copy link
Contributor

@sambolek sambolek commented Oct 4, 2018

Description

Simple change of reference (referenceContainer to referenceBlock) for Google Analytics module.

---> Backport of #18290

Fixed Issues (if relevant)

  1. Magento 2.2.5: Google Analytics not added to head correctly #16497 Magento 2.2.5: Google Analytics not added to head correctly

Manual testing scenarios

  • Observe "head.additional" is created as block app/code/Magento/Catalog/view/frontend/layout/default.xml
  • Observe "google_analytics" block is added to storefront by "referenceContainer" in app/code/Magento/GoogleAnalytics/view/frontend/layout/default.xml

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-3091 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @sambolek. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@sambolek
Copy link
Contributor Author

sambolek commented Oct 4, 2018

Hi,

actually, this pull request is a backport of a fix that was initially done for 2.3-develop ;)

@slavvka
Copy link
Member

slavvka commented Oct 4, 2018

@sambolek That's okay. That was a bot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants