Skip to content

Conversation

@sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 28, 2018

Description

Cast getStoreId() for products to int (like for categories).

Forwardport: #18086

Fixed Issues (if relevant)

  1. Inconsistent return type for getStoreId() #18079:

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @sreichel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sreichel sreichel requested a review from sidolov September 28, 2018 13:35
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3061 has been created to process this Pull Request

@sreichel
Copy link
Contributor Author

@sidolov whats wrong with this test? I dont see any problems at mentioned lines.

@magento-engcom-team
Copy link
Contributor

Hi @sreichel. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@sreichel sreichel deleted the 2.3-develop-PR-port-18086 branch October 17, 2018 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants