Skip to content

[Backport] [2.2] Changed intval($val) to (int) $val, since it is faster: #18126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2018
Merged

[Backport] [2.2] Changed intval($val) to (int) $val, since it is faster: #18126

merged 2 commits into from
Sep 24, 2018

Conversation

@dmytro-ch
Copy link
Contributor

@dmytro-ch dmytro-ch commented Sep 19, 2018

Original Pull Request

#18035

  • changed intval($val) to (int) $val, since it is faster

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 19, 2018

Hi @dmytro-ch. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch dmytro-ch changed the title [Backport] [2.3] Changed intval($val) to (int) $val, since it is faster: [Backport] [2.2] Changed intval($val) to (int) $val, since it is faster: Sep 19, 2018
@dmytro-ch dmytro-ch requested a review from rogyar September 19, 2018 05:56
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.7 milestone Sep 19, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 19, 2018

Hi @sidolov, thank you for the review.
ENGCOM-3013 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 48fe662 into magento:2.2-develop Sep 24, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 24, 2018
ENGCOM-3013: [Backport] [2.2] Changed intval($val) to (int) $val, sin…
8fb6fe1 
…ce it is faster: #18126
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 24, 2018

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidolov sidolov sidolov approved these changes

@rogyar rogyar Awaiting requested review from rogyar

Assignees

@rogyar rogyar

@sidolov sidolov

Labels

Component: Bundle Component: Catalog Component: CatalogInventory Component: CatalogWidget Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.8

Development

Successfully merging this pull request may close these issues.

5 participants

@dmytro-ch @magento-engcom-team @sidolov @rogyar @TBlindaruk