Convert string to DateTime object for languages other than English #18083

bnymn · 2018-09-16T19:12:22Z

Converting from string into PHP DateTime object is failing for locales other than en_US. This PR aims to solve this problem.

Description

DateTime class can parse a given string if it is in English, but it fails for other languages. To solve this issue, we have used IntlDateFormatter class for parsing string dates.

For cases when locale cannot be resolved, we explicitly have defined the pattern. Please refer to this line for the edge case.
https://github.com/magento/magento2/pull/18083/files#diff-9f6dc57683917f529571d34de6f14d15R335

Fixed Issues (if relevant)

Datetime Error on Newsletter Template #5037: Datetime Error on Newsletter Template

Manual testing scenarios

Login into Magento admin
On the top right corner, click on your admin username, then click Account Settings.
Change admin Interface locale to any language other than English.
Create a newsletter template
4.1. Go to Marketing -> Newsletter Template.
4.2. Add a new template if there is not any.
Go to Marketing -> Newsletter Template.
Select "Queue Newsletter" action for any template.
Set a date for Queue Date Start field.
Save newsletter.

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

magento-engcom-team · 2018-09-16T19:12:29Z

Hi @bnymn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

bnymn · 2018-09-16T19:13:07Z

@magento-engcom-team give me test instance

magento-engcom-team · 2018-09-16T19:13:12Z

Hi @bnymn. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2018-09-16T19:13:53Z

Hi @bnymn, here is your new Magento instance.
Admin access: https://pr-18083.engcom.dev.magento.com/admin
Login: admin Password: 123123q

…code style violations

…e/issue-5037

slavvka

Please fix the problems and failed tests.

slavvka · 2018-09-24T18:33:31Z

lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php

@@ -85,23 +85,31 @@ public function __construct(
    }

    /**
-     * {@inheritdoc}
+     * Return path to default timezone


You shouldn't duplicate descriptions in the implementation. They are in the interface. Please return them to {@inheritdoc}

Thank you for the explanation @slavvka . So should I just ignore these warnings then?
https://travis-ci.org/magento/magento2/jobs/429304963

Basically you could ignore those since {@inheritdoc} may be used in such cases and there's a bug in our sniffer. But it would be good if you make changes according to this guide https://devdocs.magento.com/guides/v2.3/coding-standards/docblock-standard-general.html#inheritdoc. As you could see there should be enough to remove curly braces {}

slavvka · 2018-09-24T18:36:52Z

lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php

+     * @return string
+     * @deprecated
+     */
+    public function convertConfigTimeToUtcWithPattern($date, $format = 'Y-m-d H:i:s', $pattern = 'Y-m-d H:i:s');


Adding a public method into interface marked as API is backward incompatible and therefore is forbidden (please look BIC guide https://devdocs.magento.com/guides/v2.3/contributor-guide/backward-compatible-development/). Please reimplement it. You can use the possible approach how to do that in the mentioned guide.

bnymn · 2018-10-08T13:09:39Z

@magento-engcom-team give me test instance

slavvka · 2018-10-08T16:37:29Z

...internal/Magento/Framework/Stdlib/DateTime/Timezone/LocalizedDateToUtcConverterInterface.php

+     * @return string
+     */
+    public function convertLocalizedDateToUtc($date);
+}


Please add a new line in the end

...internal/Magento/Framework/Stdlib/DateTime/Timezone/LocalizedDateToUtcConverterInterface.php

magento-engcom-team · 2018-10-24T15:07:29Z

Hi @slavvka, thank you for the review.
ENGCOM-3256 has been created to process this Pull Request

magento-engcom-team · 2018-11-06T18:08:06Z

Hi @bnymn. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

…an English #18083

bnymn added 4 commits September 16, 2018 13:58

Fix date format for different locales

ae42612

Move formatter into string conversion block

c4fa85b

Convert internationalized date into DateTime object

6bda779

Force pattern if locale not found

a4f80a9

magento-engcom-team added Partner: Webjump partners-contribution Pull Request is created by Magento Partner labels Sep 16, 2018

magento-engcom-team added Component: Framework/Stdlib Component: Newsletter Release Line: 2.3 labels Sep 16, 2018

bnymn assigned okorshenko Sep 16, 2018

bnymn changed the title ~~Feature/issue 5037~~ Convert string to DateTime object for languages other than English Sep 16, 2018

bnymn added the Event: CD-Webjump label Sep 16, 2018

ishakhsuvarov added this to the Release: 2.3.1 milestone Sep 18, 2018

bnymn added 2 commits September 21, 2018 15:14

Replaced {@inheritdoc} with the actual documentation in order to fix …

14d9528

…code style violations

Merge branch '2.3-develop' of github.com:magento/magento2 into featur…

da580fc

…e/issue-5037

slavvka requested changes Sep 24, 2018

View reviewed changes

slavvka self-assigned this Sep 24, 2018

slavvka added the Progress: needs update label Sep 24, 2018

slavvka unassigned okorshenko Sep 25, 2018

bnymn added 7 commits October 1, 2018 09:05

Use @inheritdoc and revert back code change

16a7f0b

Revert back code change to fix BiC

9315dd6

Revert back @deprecated tag

42cd228

Revert back new lines

ddeaf36

Revert back documentation change in API interface

6cc9034

Fix documentation change for code smell

28617c0

Fix documentation

fd0ab03

bnymn added 4 commits October 8, 2018 09:16

Revert back change

1b03c19

Rever-back unit test

c6c2ffe

New class and interface created for time format convertion

502e5ac

Convert local timestamp into GMT timestamp

51e8fe7

slavvka requested changes Oct 8, 2018

View reviewed changes

slavvka added 7 commits October 23, 2018 13:46

Fix docblocks

a8c7768

Fix docblock

127b1b8

Fix docblock

526bfc9

Fix static tests

edc962d

Fix static test

4fe8c7a

Fix static test

e27de55

Fix static test

0d0c210

magento-engcom-team removed the Progress: needs update label Oct 24, 2018

slavvka approved these changes Oct 24, 2018

View reviewed changes

magento-engcom-team added the Progress: accept label Oct 25, 2018

sidolov mentioned this pull request Nov 6, 2018

Datetime Error on Newsletter Template #5037

Closed

magento-engcom-team merged commit 0d0c210 into magento:2.3-develop Nov 6, 2018

magento-engcom-team added the Award: bug fix label Nov 6, 2018

magento-engcom-team pushed a commit that referenced this pull request Nov 6, 2018

ENGCOM-3256: Convert string to DateTime object for languages other th…

8435af3

…an English #18083

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Convert string to DateTime object for languages other than English #18083

Convert string to DateTime object for languages other than English #18083

Uh oh!

bnymn commented Sep 16, 2018 •

edited

Loading

Uh oh!

magento-engcom-team commented Sep 16, 2018

Uh oh!

bnymn commented Sep 16, 2018

Uh oh!

magento-engcom-team commented Sep 16, 2018

Uh oh!

magento-engcom-team commented Sep 16, 2018

Uh oh!

slavvka left a comment

Uh oh!

slavvka Sep 24, 2018

Uh oh!

bnymn Sep 24, 2018 •

edited

Loading

Uh oh!

slavvka Sep 26, 2018

Uh oh!

slavvka Sep 24, 2018

Uh oh!

bnymn commented Oct 8, 2018

Uh oh!

slavvka Oct 8, 2018

Uh oh!

Uh oh!

magento-engcom-team commented Oct 24, 2018

Uh oh!

magento-engcom-team commented Nov 6, 2018

Uh oh!

Uh oh!

Convert string to DateTime object for languages other than English #18083

Convert string to DateTime object for languages other than English #18083

Uh oh!

Conversation

bnymn commented Sep 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Fixed Issues (if relevant)

Manual testing scenarios

Contribution checklist

Uh oh!

magento-engcom-team commented Sep 16, 2018

Uh oh!

bnymn commented Sep 16, 2018

Uh oh!

magento-engcom-team commented Sep 16, 2018

Uh oh!

magento-engcom-team commented Sep 16, 2018

Uh oh!

slavvka left a comment

Choose a reason for hiding this comment

Uh oh!

slavvka Sep 24, 2018

Choose a reason for hiding this comment

Uh oh!

bnymn Sep 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

slavvka Sep 26, 2018

Choose a reason for hiding this comment

Uh oh!

slavvka Sep 24, 2018

Choose a reason for hiding this comment

Uh oh!

bnymn commented Oct 8, 2018

Uh oh!

slavvka Oct 8, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

magento-engcom-team commented Oct 24, 2018

Uh oh!

magento-engcom-team commented Nov 6, 2018

Uh oh!

Uh oh!

bnymn commented Sep 16, 2018 •

edited

Loading

bnymn Sep 24, 2018 •

edited

Loading