Skip to content

Conversation

@mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Sep 11, 2018

Description

Direct type casting is up to 6x faster than using casting functions like floatval(). So this pull request replaces the floatval() functions by direct type casting to (float).

Fixed Issues (if relevant)

  1. Replace floatval() function by using direct type casting to (float)  #16848: Replace floatval() function by using direct type casting to (float)

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Component: Framework/Filter Component: Framework/Setup USE ONLY for FRAMEWORK RELATED BUG! E.g If bug occurs during Catalog Setup use just Catalog labels Sep 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cleanup Component: Framework/Filter Component: Framework/Setup USE ONLY for FRAMEWORK RELATED BUG! E.g If bug occurs during Catalog Setup use just Catalog Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants