Skip to content

Conversation

@eduard13
Copy link
Contributor

Description

This PR adds missing unit tests for CategoryProcessUrlRewriteMovingObserver class:

  • \Magento\CatalogUrlRewrite\Observer\CategoryProcessUrlRewriteMovingObserver

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@eduard13 eduard13 requested a review from rogyar September 10, 2018 14:26
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: CatalogUrlRewrite labels Sep 10, 2018
@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@eduard13
Copy link
Contributor Author

@rogyar could you please have a look at these failed tests, maybe you can suggest me something here ? As I don't get what's the problem here.
Thank you.

@rogyar
Copy link
Contributor

rogyar commented Sep 15, 2018

@eduard13 the number of class dependencies ideally should be less than 13. But for unit tests it's not a critical point

@magento-engcom-team magento-engcom-team merged commit 3c2d609 into magento:2.2-develop Sep 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

1 similar comment
@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: CatalogUrlRewrite Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants