Skip to content

Implemented 17964: Backend Order creation Authorizenet: If invalid cr… #17986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 4, 2018
Merged

Implemented 17964: Backend Order creation Authorizenet: If invalid cr… #17986

merged 3 commits into from
Oct 4, 2018

Conversation

@passtet
Copy link
Contributor

@passtet passtet commented Sep 8, 2018

…edit card number is entered the loader keeps spinning forever without any error message

Description

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@passtet
Implemented 17964: Backend Order creation Authorizenet: If invalid cr…
41def56 
…edit card number is entered the loader keeps spinning forever without any error message
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 8, 2018

Hi @passtet. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

williankeller
williankeller suggested changes Sep 10, 2018
View reviewed changes
app/code/Magento/Sales/view/adminhtml/web/order/create/scripts.js Outdated
{
jQuery('#edit_form').trigger('processStart');
jQuery('#edit_form').trigger('submitOrder');
if(jQuery('#edit_form').valid()) {
Copy link
Member

@williankeller williankeller Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @passtet, please add space between if and (.
And what about move jQuery('#edit_form') to a variable? Then use it to validate and trigger methods.

Copy link
Contributor Author

@passtet passtet Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@williankeller done. I would actually refactore the whole file for those, but I guess that there would be too many conflicts :)

@VladimirZaets VladimirZaets self-assigned this Sep 18, 2018
passtet and others added 2 commits September 20, 2018 18:39
@passtet
Refactored Implemented 17964: Backend Order creation Authorizenet: If…
1f08cd1 
… invalid credit card number is entered the loader keeps spinning forever without any error message
Fixed code style issue
edea5c5
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 4, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 4, 2018

Hi @sidolov, thank you for the review.
ENGCOM-3093 has been created to process this Pull Request

@ghost ghost mentioned this pull request Oct 4, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit edea5c5 into magento:2.2-develop Oct 4, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 4, 2018
ENGCOM-3093: Implemented 17964: Backend Order creation Authorizenet: …
f0a4ca9 
…If invalid cr… #17986
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 4, 2018

Hi @passtet. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@mage2pratik mage2pratik mentioned this pull request Oct 5, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidolov sidolov sidolov approved these changes

+1 more reviewer

@williankeller williankeller williankeller requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@VladimirZaets VladimirZaets

@sidolov sidolov

Labels

Area: Frontend Component: Sales Progress: accept Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.8

Development

Successfully merging this pull request may close these issues.

5 participants

@passtet @magento-engcom-team @williankeller @sidolov @VladimirZaets