Skip to content

Conversation

@TBlindaruk
Copy link
Member

[2.3] changed intval($val) to (int) $val, since (int) $val is faster.

@magento-engcom-team
Copy link
Contributor

Hi @TBlindaruk. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@TBlindaruk TBlindaruk force-pushed the changed_intval_to_int_casting branch 2 times, most recently from 4b73c06 to 0372245 Compare September 5, 2018 21:34
@magento-engcom-team
Copy link
Contributor

Hi @TBlindaruk. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants