Skip to content

Conversation

ronak2ram
Copy link
Member

Description

I do change in grid.phtml. There is a missing button type. If we did not put button type then button work as a submit button.

Fixed Issues (if relevant)

  1. Next Page button triggered when filtering Customer grid #17789: Next Page button triggered when filtering Customer grid

Manual testing scenarios

  1. Go to "Sales -> Orders"
  2. "Create new order"
  3. Customer grid is displayed
  4. Focus on any column filter (i.e. text box in email column)
  5. Press ENTER to trigger the filter

Expected result

  1. Filter's AJAX call is triggered
  2. Results don't change because the filter input was empty
  3. Grid is still showing the same page.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@miguelbalparda
Copy link
Contributor

Hi @ronak2ram! Thanks for your contribution. Can you please create a port to 2.3? We are trying to have everything merged in 2.3 before proceeding with other branches. Thanks!!

@ronak2ram
Copy link
Member Author

ronak2ram commented Aug 30, 2018

Hello @miguelbalparda
I created port for 2.3. Please check pull #17874

@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-2920 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@ronak2ram
Copy link
Member Author

ronak2ram commented Sep 5, 2018

Hello @magento-engcom-team
I read this(https://github.com/magento/magento2/wiki/Contribution-Rewards) document.
As per this document I think Bug fix achievement missing for this pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants