Skip to content

Conversation

@jignesh-baldha
Copy link
Member

This PR will add checkout_cart_product_add_before event.

Fixed Issues (if relevant)

  1. Add checkout_cart_product_add_before event #17830: Add checkout_cart_product_add_before event

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@osrecio osrecio self-assigned this Aug 29, 2018
@okorshenko
Copy link
Contributor

Hi @jean-bernard-valentaten thank you for your contributions. Unfortunately, all new features/improvements/code cleanup should go to the 2.3-develop branch. Only critical bug fixes can be delivered to 2.2-develop branch.
Just FYI: there is PR to 2.3-develop branch with the similar improvement. #18080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants