Skip to content

Conversation

@nmalevanec
Copy link
Contributor

@nmalevanec nmalevanec commented Aug 21, 2018

Original Pull Request

#16849

Description

Direct type casting is up to 6x faster than using casting functions like strval(). So this pull request replaces the strval() functions by direct type casting to (string).

Similar PRs:

#16422 Replace intval() function by using direct type casting to (int) where no default value is needed
#16848 Replace floatval() function by using direct type casting to (float)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2851 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 9f624e2 into magento:2.3-develop Sep 4, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 4, 2018
@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants