Skip to content

Conversation

@nmalevanec
Copy link
Contributor

Original Pull Request

#13133

Description

If PayPal checkout is used and, for whatever reason, the email sender throws an exception (maybe third-party integration fails to send), the PayPal order is still placed but the user is shown Something went wrong message and ends up in review page.

This is in contrast to a cash payment or other payment method where the order is placed successfully.

This is because other payment methods run through this checkout, that wraps orderSender in a try/catch:
https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Checkout/Model/Type/Onepage.php#L731

This PR replicates that try/catch for PayPal.

Manual testing scenarios

  1. Edit OrderSender to throw an Exception to simulate failed integration email send
  2. Checkout with PayPal
  3. Order is created but you are sent with error to review page
  4. Do same with cash checkout
  5. Order is successful

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@nmalevanec nmalevanec closed this Aug 21, 2018
@nmalevanec nmalevanec deleted the 2.3-develop-PR-port-13133 branch August 21, 2018 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants