Skip to content

Fixing typo in method name for Magento_Paypal method. #17687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixing typo in method name for Magento_Paypal method. #17687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion app/code/Magento/Paypal/Model/AbstractConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,15 +224,26 @@ protected function _prepareValue($key, $value)
*/
public function shouldUseUnilateralPayments()
{
return $this->getValue('business_account') && !$this->isWppApiAvailabe();
return $this->getValue('business_account') && !$this->isWppApiAvailable();
}

/**
* Check whether WPP API credentials are available for this method
*
* @deprecated
* @return bool
*/
public function isWppApiAvailabe()
{
return $this->isWppApiAvailable();
}

/**
* Check whether WPP API credentials are available for this method
*
* @return bool
*/
public function isWppApiAvailable()
{
return $this->getValue('api_username')
&& $this->getValue('api_password')
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Paypal/Model/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,7 @@ public function isMethodAvailable($methodCode = null)
}
break;
case self::METHOD_BILLING_AGREEMENT:
$result = $this->isWppApiAvailabe();
$result = $this->isWppApiAvailable();
break;
}
return $result;
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/Paypal/Test/Unit/Model/AbstractConfigTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,14 +189,14 @@ public function getValueDataProvider()
*
* @dataProvider isWppApiAvailabeDataProvider
*/
public function testIsWppApiAvailabe($returnMap, $expectedValue)
public function testIsWppApiAvailable($returnMap, $expectedValue)
{
$this->config->setMethod('paypal_express');
$this->scopeConfigMock->expects($this->any())
->method('getValue')
->willReturnMap($returnMap);

$this->assertEquals($expectedValue, $this->config->isWppApiAvailabe());
$this->assertEquals($expectedValue, $this->config->isWppApiAvailable());
}

/**
Expand Down