Skip to content

Conversation

@jignesh-baldha
Copy link
Member

Original Pull Request

#16777

Description

  • fix not working translation on Cart Page for error message.

Manual testing scenarios

Pre-conditions

  1. Enabled Inline Translates.
  2. Bundle product #P1 - visible and saleable.
  3. Enabled multishipping.

Steps To Reproduce

  1. Go to Frontend.
  2. Add bundle product to cart.
  3. Go to cart page.
  4. Go to admin panel.
  5. Find bundle product #P1 in Products -> Catalog.
  6. Edit options (e.g. change order of items) and save the product.
  7. Flush cache (System -> Tools -> Cache Management -> Flush Magento Cache).
  8. Go to frontend.
  9. Refresh the page.

Expected Result:

  1. Error messages are shown.
  2. All messages are translatable.

Actual Result:

  1. Error messages are shown.
  2. The message 'The required options you selected are not available.' is not inline translatable.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

al.kravchuk added 2 commits August 14, 2018 19:05
…ted bundle option. - change plugin sort order in case to prevent loading of not translatable messages for Localized exception in beforeDispatch plugin.
@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Aug 15, 2018

Hi @jignesh-baldha , I'm closing this PR as a duplicate for #16778
Thank you!

@sidolov sidolov closed this Aug 15, 2018
@jignesh-baldha
Copy link
Member Author

@sidolov Could please remove card for PR #16777 from Ready to Port

@jignesh-baldha jignesh-baldha deleted the 2.3-develop-PR-port-16777 branch August 16, 2018 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants