Skip to content

Conversation

jignesh-baldha
Copy link
Member

@jignesh-baldha jignesh-baldha commented Aug 14, 2018

Original Pull Request

#17590

Description

This PR adds missing unit test for \Magento\Braintree\Model\InstantPurchase\CreditCard\TokenFormatter class

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sidolov
Copy link
Contributor

sidolov commented Aug 15, 2018

Hi @jignesh-baldha , please, fix the test according to used PHPUnit version

@sidolov sidolov self-assigned this Aug 15, 2018
@sidolov
Copy link
Contributor

sidolov commented Aug 28, 2018

Hi @jignesh-baldha , I'm closing this PR because created unit test is not applicable for current release line due to absence of Magento\Braintree\Model\InstantPurchase\CreditCard\TokenFormatter
Thank you for your contribution!

@sidolov sidolov closed this Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants