Skip to content

Conversation

@tiagosampaio
Copy link
Member

Replacing deprecated methods from Magento_Sales module.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Aug 7, 2018

@magento-engcom-team combine 17409

@magento-engcom-team
Copy link
Contributor

Hi @sidolov. Thank you for your request. I'm working on combining the pull requests for you

@magento-engcom-team
Copy link
Contributor

@tiagosampaio all pull requests have been successfully combined together:

@sidolov
Copy link
Contributor

sidolov commented Aug 7, 2018

@magento-engcom-team combine 17412

@magento-engcom-team
Copy link
Contributor

Hi @sidolov. Thank you for your request. I'm working on combining the pull requests for you

@sidolov sidolov self-assigned this Aug 7, 2018
@magento-engcom-team
Copy link
Contributor

@tiagosampaio all pull requests have been successfully combined together:

@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@tiagosampaio tiagosampaio deleted the 2.3-develop-012 branch August 16, 2018 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants