Skip to content

[Braintree] Removed unnecessary unsets from models #17372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2018
Merged

[Braintree] Removed unnecessary unsets from models #17372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/code/Magento/Braintree/Gateway/Http/Client/TransactionRefund.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ class TransactionRefund extends AbstractTransaction
protected function process(array $data)
{
$storeId = $data['store_id'] ?? null;
// sending store id and other additional keys are restricted by Braintree API
unset($data['store_id']);

return $this->adapterFactory->create($storeId)
->refund($data['transaction_id'], $data[PaymentDataBuilder::AMOUNT]);
Expand Down
2 changes: 0 additions & 2 deletions app/code/Magento/Braintree/Gateway/Http/Client/TransactionSubmitForSettlement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ class TransactionSubmitForSettlement extends AbstractTransaction
protected function process(array $data)
{
$storeId = $data['store_id'] ?? null;
// sending store id and other additional keys are restricted by Braintree API
unset($data['store_id']);

return $this->adapterFactory->create($storeId)
->submitForSettlement($data[CaptureDataBuilder::TRANSACTION_ID], $data[PaymentDataBuilder::AMOUNT]);
Expand Down
2 changes: 0 additions & 2 deletions app/code/Magento/Braintree/Gateway/Http/Client/TransactionVoid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ class TransactionVoid extends AbstractTransaction
protected function process(array $data)
{
$storeId = $data['store_id'] ?? null;
// sending store id and other additional keys are restricted by Braintree API
unset($data['store_id']);

return $this->adapterFactory->create($storeId)->void($data['transaction_id']);
}
Expand Down