Skip to content

[Backport] Fixed a couple of typos #17338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Backport] Fixed a couple of typos #17338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Ui/view/base/web/js/grid/columns/multiselect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ define([
* Returns identifier of a record.
*
* @param {*} id - Id of a record or its' index in a rows array.
* @param {Boolean} [isIndex=false] - Flag that specifies whith what
* @param {Boolean} [isIndex=false] - Flag that specifies with what
* kind of identifier we are dealing with.
* @returns {*}
*/
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/Ui/view/base/web/js/grid/filters/filters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ define([
/**
* Creates filter component configuration associated with the provided column.
*
* @param {Column} column - Column component whith a basic filter declaration.
* @param {Column} column - Column component with a basic filter declaration.
* @returns {Object} Filters' configuration.
*/
buildFilter: function (column) {
Expand Down Expand Up @@ -331,7 +331,7 @@ define([
},

/**
* Finds filters whith a not empty data
* Finds filters with a not empty data
* and sets them to the 'active' filters array.
*
* @returns {Filters} Chainable.
Expand Down
2 changes: 1 addition & 1 deletion dev/tests/integration/testsuite/Magento/Tax/Model/TaxRuleRepositoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public function testSave()
* @expectedExceptionMessage No such entity with taxRuleId = 9999
* @magentoDbIsolation enabled
*/
public function testSaveThrowsExceptionIdTargetTaxRulDoesNotExist()
public function testSaveThrowsExceptionIdIfTargetTaxRuleDoesNotExist()
{
$taxRuleDataObject = $this->taxRuleFactory->create();
$taxRuleDataObject->setId(9999)
Expand Down